Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[7.x] Replace placeholder for dots and asterisks in validator #33367

Merged
merged 3 commits into from
Jun 29, 2020

Conversation

themsaid
Copy link
Member

This PR fixes: #33357

@taylorotwell
Copy link
Member

Can we update a test for this?

@themsaid
Copy link
Member Author

@taylorotwell test added

@taylorotwell taylorotwell merged commit 92cf9d9 into laravel:7.x Jun 29, 2020
@@ -3880,6 +3880,32 @@ public function testPassingSlashVulnerability()
$this->assertTrue($v->fails());
}

public function testPlaceholdersAreReplaced()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This test does not actually covers the problem described in the related issue: it does not check whether validated data array contains the correct key or not.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to open a PR with more tests. That's always a good thing :)

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Already done: #33932

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Validator dotPlaceholder breaks key names returned
3 participants